Professions help

So should I of chosen Herbalism and Mining? Thanks for the help!

No, you can't.
The 3 possible combos are Mining+Jewelry, Mining+Smithing, and Herbalism+Alchemy.
Basically: Jewelry can make some pretty fantastic accessories. It's very common for them to come out with potential, so 3% or 6%stat earrings are very common and cheap now. You can also make some good rings, but only one of them can have potential, and it's very hard to get the recipe for it (drops from zakum at a low rate). The belts and shoulderpads that you can make are heavily outclassed by the silent crusade ones. You can also make face accessories (only mask), which can have wAtt/mAtt (basically only for if you didn't get DB blood mask).
Smithing: Weapons and equips. Reverse and timeless equips, and level 130 equips. Easy to get %stat equips now, and pre-potted weapons (screw you, 90% pot scrolls). The amount of PoT's that you need for reverse weps/equips has been lowered significantly, but you need recipes for them (iirc, you need recipes for everything 100+, and select things below 100.
Alchemy: Fusing and extracting, plus your own private potion shop. Fusing works this way: buy random equips from a town, fuse them, hope the come out with pot, reveal pot, hope for %stat, rinse and repeat. Basically the equivalent of smithing, but you need to have 2 of the equip in the first place to fuse (harder for high level equips). Extracting is good for those pesky equips in your inventory that no one will ever want in their right mind. Extract them to get item crystals (needed for accessories/equips/weapons), and to free up some room in your inventory. Can charge quite a bit for high-level extractors (or get fames if you set it up for free, either one works). Potion shop is quite self explanatory, except for that you can also make buff potions or transformation potions, which can raise stats/attack or turn you into a monster/giant for a period of time, respectively.